On Tue, Jun 22, 2021 at 09:11:26AM +0900, Michael Paquier wrote:
> On Sun, Jun 20, 2021 at 11:15:08PM +0500, Andrey Borodin wrote:
> > I have some small questions.
> >
> > 1.
> > + report_invalid_record(record, "image at %X/%X
> > compressed with %s not supported, block %d",
> > + (uint32)
> > (record->ReadRecPtr >> 32),
> > + (uint32)
> > record->ReadRecPtr,
> > + "lz4",
> > + block_id);
> > Can we point out to user that the problem is in the build?
>
> What about the following error then? Say:
> "image at %X/%X compressed with LZ4 not supported by build, block
> %d".
The two similar, existing messages are:
+#define NO_LZ4_SUPPORT() \
+ ereport(ERROR, \
+ (errcode(ERRCODE_FEATURE_NOT_SUPPORTED), \
+ errmsg("unsupported LZ4 compression method"), \
+ errdetail("This functionality requires the server to
be built with lz4 support."), \
+ errhint("You need to rebuild PostgreSQL using
--with-lz4.")))
src/bin/pg_dump/pg_backup_archiver.c: fatal("cannot
restore from compressed archive (compression not supported in this
installation)");
src/bin/pg_dump/pg_backup_archiver.c: pg_log_warning("archive is
compressed, but this installation does not support compression -- no data will
be available");
src/bin/pg_dump/pg_dump.c: pg_log_warning("requested compression
not available in this installation -- archive will be uncompressed");
--
Justin
