On Mon, Jun 28, 2021 at 10:17:55AM +1000, Peter Smith wrote: > IIUC for the case ALTER_SUBSCRIPTION_DROP_PUBLICATION it looks like > the uninitialized copy_data local stack var would remain uninitialized > (undefined) still at the time it is passed at > AlterSubscription_refresh(sub, copy_data);
Yes, that's wrong. AlterSubscription_refresh() would happily look at this uninitialized value when performing a refresh with this command. That's the only code path using parse_subscription_options() with this pattern. Applied on HEAD. -- Michael
signature.asc
Description: PGP signature
