On 6/21/21 8:23 PM, Michael Paquier wrote: > On Sun, Jun 20, 2021 at 01:24:04PM -0400, Andrew Dunstan wrote: >> Tests pass with the attached patch, which puts the setting in the >> Makefile for the recovery tests. The script itself doesn't need any >> changing. > +REGRESS_SHLIB=$(abs_top_builddir)/src/test/regress/regress$(DLSUFFIX) > +export REGRESS_SHLIB > It may be better to add a comment here explaning why REGRESS_SHLIB is > required in this Makefile then? > > While on it, could we split those commands into multiple lines and > reduce the noise of future diffs? Something as simple as that would > make those prove commands easier to follow: > +cd $(srcdir) && TESTDIR='$(CURDIR)' \ > + $(with_temp_install) \ > + PGPORT='6$(DEF_PGPORT)' \ > + PG_REGRESS='$(CURDIR)/$(top_builddir)/src/test/regress/pg_regress' \ > + REGRESS_SHLIB= '$(abs_top_builddir)/src/test/regress/regress$(DLSUFFIX)' \ > + $(PROVE) $(PG_PROVE_FLAGS) $(PROVE_FLAGS) $(if > $(PROVE_TESTS),$(PROVE_TESTS),t/*.pl) > > There are other places where this could happen, but the TAP commands > are particularly long.
OK, done. cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com
