On Sat, Jul 3, 2021 at 10:03 PM Tom Lane <t...@sss.pgh.pa.us> wrote:
>
> Bharath Rupireddy <bharath.rupireddyforpostg...@gmail.com> writes:
> > The patch basically looks good to me except a minor comment to have a
> > local variable for var->varattno which makes the code shorter.
>
> Here's a restructured version that uses rangetable data for the
> simple-relation case too. I also modified the relevant test cases
> so that it's visible that we're reporting aliases not true names.
How about making the below else if statement and the attname
assignment into a single line? They are falling below the 80 char
limit.
else if (colno > 0 && colno <= list_length(rte->eref->colnames))
attname = strVal(list_nth(rte->eref->colnames, colno - 1));
Otherwise the v8 patch looks good to me.
Regards,
Bharath Rupireddy.
