‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
On Monday, July 12th, 2021 at 17:07, <gkokola...@pm.me> wrote: > ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐ > > On Monday, July 12th, 2021 at 13:04, Michael Paquier mich...@paquier.xyz > wrote: > > > On Mon, Jul 12, 2021 at 09:42:32AM +0000, gkokola...@pm.me wrote: > > > > > This to my understanding means that gzip is expected to exist. > > > > > > If this is correct, then simply checking for the headers should > > > > > > suffice, since that is the only dependency for the files to be > > > > > > created. > > > > You cannot expect this to work on Windows when it comes to MSVC for > > > > example, as gzip may not be in the environment PATH so the test would > > > > fail hard. Let's just rely on $ENV{GZIP} instead, and skip the test > > > > if it is not defined. > > I am admittedly not so well versed on Windows systems. Thank you for > > informing me. > > Please find attached v3 of the patch where $ENV{GZIP_PROGRAM} is used > > instead. To the best of my knowledge one should avoid using $ENV{GZIP} > > because that would translate to the obsolete, yet used environment > > variable GZIP which holds a set of default options for gzip. In essence > > it would be equivalent to executing: > > GZIP=gzip gzip --test <files> > > which can result to errors similar to: > > gzip: gzip: non-option in GZIP environment variable > After a bit more thinking, I went ahead and added on top of v3 a test verifying that the gzip program can actually be called. Please find v4 attached. Cheers, //Georgios > > > Michael
v4-0001-Introduce-pg_receivewal-gzip-compression-tests.patch
Description: Binary data