Re: 回复： Why is XLOG_FPI_FOR_HINT always need backups?

[Fujii Masao]

On 2021/07/19 10:16, Kyotaro Horiguchi wrote:

At Sat, 17 Jul 2021 00:14:34 +0900, Fujii Masao <masao.fu...@oss.nttdata.com> 
wrote in

Thanks for updating the patch! It basically looks good to me.

                 * Full-page image (FPI) records contain nothing else but a 
backup
                 * block (or multiple backup blocks). Every block reference must
                 * include a full-page image - otherwise there would be no 
point in
                 * this record.

The above comment also needs to be updated?

In short, no.  In contrast to the third paragraph, the first paragraph
should be thought that it is describing XLOG_FPI.  However, actually
it is not super obvious so it's better to make it clearer. Addition to
that, it seems to me (yes, to *me*) somewhat confused between "block
reference", "backup block" and "full-page image". So I'd like to
adjust the paragraph as the following.

Understood. Thanks for updating the patch!

I slightly modified the comments and pushed the patch. Thanks!

Regards,

--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION