On Thu, Jul 15, 2021 at 3:50 PM osumi.takami...@fujitsu.com <osumi.takami...@fujitsu.com> wrote: > I started to test this patch but will give you some really minor quick > feedbacks. > > (1) pg_logical_slot_get_binary_changes() params. > > Technically, looks better to have proto_version 3 & two_phase option for the > function > to test empty prepare ? I felt proto_version 1 doesn't support 2PC. > [1] says "The following messages (Begin Prepare, Prepare, Commit Prepared, > Rollback Prepared) > are available since protocol version 3." Then, if the test wants to skip > empty *prepares*, > I suggest to update the proto_version and set two_phase 'on'.
Updated accordingly. > (2) The following sentences may start with a lowercase letter. > There are other similar codes for this. > > + elog(DEBUG1, "Skipping replication of an empty transaction"); Fixed this. I've addressed these comments in version 8 of the patch. regards, Ajin Cherian Fujitsu Australia
