On 3/23/21 1:39 AM, Justin Pryzby wrote: > On Tue, Jan 19, 2021 at 03:03:31PM -0600, Justin Pryzby wrote: >> On Wed, Dec 30, 2020 at 12:33:56PM +0000, Simon Riggs wrote: >>> There are no tests for the new functionality, please could you add some? >> >> Did you look at the most recent patch? >> >> +CREATE ACCESS METHOD heapdup TYPE TABLE HANDLER heap_tableam_handler; >> +CREATE TABLE likeam() USING heapdup; >> +CREATE TABLE likeamlike(LIKE likeam INCLUDING ALL); >> >>
It seems like this should error to me: CREATE ACCESS METHOD heapdup TYPE TABLE HANDLER heap_tableam_handler; CREATE TABLE likeam1() USING heap; CREATE TABLE likeam2() USING heapdup; CREATE TABLE likeamlike( LIKE likeam1 INCLUDING ACCESS METHOD, LIKE likeam2 INCLUDING ACCESS METHOD ); At the very least, the documentation should say that the last one wins. -- Vik Fearing