On Fri, Aug 27, 2021 at 10:05 AM Andrey Borodin <x4...@yandex-team.ru> wrote: > There is a small bug > + /* > + * Take restore_command from the postgresql.conf only if it is not > already > + * provided as a command line option. > + */ > + if (!restore_wal && restore_command == NULL) > return; > > I think we should use condition (!restore_wal || restore_command != NULL). >
Yes, you are right, thanks. Attached is a fixed version. Tests were passing since PostgresNode->enable_restoring is adding restore_command to the postgresql.conf anyway. > > Besides this patch looks good and is ready for committer IMV. > -- Alexey Kondratov
v2-0001-Allow-providing-restore_command-as-a-command-line.patch
Description: Binary data
