On 9/2/21, 12:54 AM, "Michael Paquier" <mich...@paquier.xyz> wrote: > Thanks. Anyway, we don't really need huge_pages_required on Windows, > do we? The following docs of Windows tell what do to when using large > pages: > https://docs.microsoft.com/en-us/windows/win32/memory/large-page-support > > The backend code does that as in PGSharedMemoryCreate(), now that I > look at it. And there is no way to change the minimum large page size > there as far as I can see because that's decided by the processor, no? > There is a case for shared_memory_size on Windows to be able to adjust > the sizing of the memory of the host, though.
Yeah, huge_pages_required might not serve much purpose for Windows. We could always set it to -1 for Windows if it seems like it'll do more harm than good. > At the end it would be nice to not finish with two GUCs. Both depend > on the reordering of the actions done by the postmaster, so I'd be > curious to hear the thoughts of others on this particular point. Of course. It'd be great to hear others' thoughts on this stuff. Nathan
