On Wed, Sep 22, 2021 at 11:31 AM Amit Kapila <amit.kapil...@gmail.com> wrote:
>
> On Tue, Sep 21, 2021 at 11:39 PM vignesh C <vignes...@gmail.com> wrote:
> >
> > On Tue, Sep 21, 2021 at 9:03 AM Greg Nancarrow <gregn4...@gmail.com> wrote:
> > >
> > > On Fri, Sep 17, 2021 at 10:09 PM vignesh C <vignes...@gmail.com> wrote:
> > > >
> > > > Attached v29 patch has the fixes for the same.
> > > >
> > >
> > > Some minor comments on the v29-0002 patch:
> > >
> > > (1)
> > > In get_object_address_publication_schema(), the error message:
> > >
> > > + errmsg("publication tables of schema \"%s\" in publication \"%s\"
> > > does not exist",
> > >
> > > isn't grammatically correct. It should probably be:
> > >
> > > + errmsg("publication tables of schema \"%s\" in publication \"%s\" do
> > > not exist",
> >
> > Modified
> >
>
> I still see the old message in v30. But I have a different suggestion
> for this message. How about changing it to: "publication schema \"%s\"
> in publication \"%s\" does not exist"? This will make it similar to
> other messages and I don't see the need here to add 'tables' as we
> have it in grammar.Modified The v32 patch attached at [1] handles the above. [1] - https://www.postgresql.org/message-id/CALDaNm1R-xbQvz4LU5OXu3KKwbWOz3uDcT_YjRU6V0R5FZDYDg%40mail.gmail.com Regards, Vignesh
