Greg Smith wrote: > > 1) On "pg_ctl stop|restart -m smart", check if online backup is > > in progress and do not shutdown in this case (treat the online > > backup like an open connection). > > As long as you give a warning as to the cause. While you're in there, I > think more output in general about the reason why a smart shutdown failed > would be nice as well.
I'll look what I can do. > > 2) On "pg_ctl stop|restart -m fast", remove backup_label after > > the server has been brought down successfully. > > And you need a warning here as well about this fact. I think the actual > details associated with that label should be both printed and put into the > logs at this time, so you know which backup you just hosed. Sounds right. > Maybe the label file could get renamed instead? I agree. > There are three options here for how "-m fast" could handle things: > > 1) Warning, remove backup label. I prefer that. Thanks for the feedback, Laurenz Albe -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
