Joshua D. Drake wrote: > On Wed, 23 Apr 2008 17:44:43 -0400 > Alvaro Herrera <[EMAIL PROTECTED]> wrote: > > > Joshua D. Drake wrote: > > Ahh o.k. Now I have a complaint. :) I happily removed the whitespace > where I saw this, "%s \n" (for example) but the whitespace above is for > readability. Consider: > > To quit psql type \q. > > I am trying to avoid the silly newbie saying, "I typed \q. and it did > nothing".
I know, which is why I suggested rewording the messages so that the command is somewhere other than the end of the sentence. (This was about 4 messages back in the thread). > Maybe I am being overly cautious? No, I think it's a reasonable thing to consider. > > > --- 158,164 ---- > > > /* DB server user name */ > > > case 'n': > > > if (pset.db) > > > ! strlcpy(buf, > > > session_username(), sizeof(buf)); break; > > > > > > case '0': > > > > Please remove this hunk. (In general make sure there are no useless > > hunks in the diff.) > > Well to be honest, I wouldn't have known it was useless as I didn't > write or purposely modify that part of the code. Right. I suggest you open the file in "meld" which allows you to easily remove the offending extraneous difference. Of course, you can do it in Vim or Emacs directly, but I don't think Joe can do anything of the sort ... but we're not about to enter another editor flamewar, now, are we? -- Alvaro Herrera http://www.CommandPrompt.com/ PostgreSQL Replication, Consulting, Custom Development, 24x7 support -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
