Magnus, Please, take a look at my implementation of stat(). It has at least two advantages: it's faster and doesn't have a bug with local-to-UTC time conversion that native msvc's stat() has. Maybe it will be useful.
Thank you. -----Original Message----- From: Magnus Hagander [mailto:[EMAIL PROTECTED] Sent: Tuesday, April 29, 2008 4:54 PM To: Zubkovsky, Sergey Cc: Andrew Dunstan; Tom Lane; Alvaro Herrera; Gregory Stark; [EMAIL PROTECTED] Subject: Re: [HACKERS] [DOCS] pg_total_relation_size() and CHECKPOINT I already applied a different patch for this quite some time ago. So what's in HEAD (and current in 8.3 and 8.2) should be fixed already. //Magnus Zubkovsky, Sergey wrote: > Hi, > > Here is the patch. > Check it, please. > > Locations of the added files: > src\include\port\win32_msvc\sys\stat.inl > src\port\stat_pg_fixed.c > > > Thank you. > > > -----Original Message----- > From: Andrew Dunstan [mailto:[EMAIL PROTECTED] > Sent: Saturday, March 29, 2008 4:18 PM > To: Zubkovsky, Sergey > Cc: Tom Lane; Alvaro Herrera; Gregory Stark; > pgsql-hackers@postgresql.org; Magnus Hagander > Subject: Re: [HACKERS] [DOCS] pg_total_relation_size() and CHECKPOINT > > > > > Zubkovsky, Sergey wrote: >> In the prepared custom build of PG 8.3.1 the native MSVC's stat() was > rewrote by adding GetFileAttributesEx() to correct stat's st_size value. >> I had seen that a result of MSVC's stat() and a result of > GetFileAttributesEx() may be differ by the file size values at least. >> The most important thing is the test in the original post >> ( http://archives.postgresql.org/pgsql-docs/2008-03/msg00041.php ) >> doesn't reproduce any inconsistence now. >> All work fine. >> >> This was tested on my WinXP SP2 platform but I suppose it will work on > any NT-based OS. >> >> > > > If you have a patch, please send it to the -patches list. > > cheers > > andrew -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
