Magnus Hagander wrote: > Tom Lane wrote: > > [EMAIL PROTECTED] (Magnus Hagander) writes: > > > Convert wal_sync_method to guc enum. > > > > Buildfarm says you broke things for Windows. > > Yeah, working on that with Dave. First part was to unbreak the error > message so we can actually figure out what's broken :-( >
I need to leave for a couple of hours, will look again when I get back. But so far, I'm quite surprised. Here's my reasoning, please poke holes in it :-) 1) Win32 always defines O_DSYNC (win32.h) 2) That means we should always define OPEN_DATASYNC_FLAG (xlogdefs.h, line 107) 3) That means that the error should not happen at all, because of xlog.c line 6358. Anybody who can kill this argument before I get back ;-) It's obviously flawed somewhere... //Magnus -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
