Joshua D. Drake wrote:
> We got the comment on the docs:
> 
> log_filename(string) is misleading, since it really doesn't use a
> strftime pattern, but instead a reimplementation of strftime, in order
> to be cross-platform. There is no documentation on this except to look
> in src/timezone/strftime.c (the function is called pg_strftime)

Correct.  I propose the attached patch.

-- 
Alvaro Herrera                                http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.
Index: config.sgml
===================================================================
RCS file: /home/alvherre/cvs/pgsql/doc/src/sgml/config.sgml,v
retrieving revision 1.179
diff -c -p -r1.179 config.sgml
*** config.sgml	19 May 2008 18:08:15 -0000	1.179
--- config.sgml	6 Jun 2008 21:52:45 -0000
*************** local0.*    /var/log/postgresql
*** 2428,2435 ****
          <varname>log_filename</varname> were <literal>server_log</literal>,
          then the chosen file name would be <literal>server_log.1093827753</>
          for a log starting at Sun Aug 29 19:02:33 2004 MST.
!         This parameter can only be set in the <filename>postgresql.conf</>
!         file or on the server command line.
         </para>
         <para>
          If CSV-format output is enabled in <varname>log_destination</>,
--- 2428,2435 ----
          <varname>log_filename</varname> were <literal>server_log</literal>,
          then the chosen file name would be <literal>server_log.1093827753</>
          for a log starting at Sun Aug 29 19:02:33 2004 MST.
!         Note that the system's <systemitem>strftime</systemitem> is not used
!         directly, so platform-specific (nonstandard) extensions do not work.
         </para>
         <para>
          If CSV-format output is enabled in <varname>log_destination</>,
*************** local0.*    /var/log/postgresql
*** 2440,2445 ****
--- 2440,2449 ----
          In the case of the example above, the CSV
          file name will be <literal>server_log.1093827753.csv</literal>.
         </para>
+        <para>
+         This parameter can only be set in the <filename>postgresql.conf</>
+         file or on the server command line.
+        </para>
        </listitem>
       </varlistentry>
  
-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Reply via email to