On Jul 14, 2008, at 06:05, Andrew Dunstan wrote:

You can certainly add any tests you like. But the buildfarm does all its regression tests using an install done with --no-locale. Any test that requires some locale to work, or make sense, should probably not be in your Makefile's REGRESS target.

Well, unless the display of the characters would be broken (the build farm databases use UTF-8, no?), the output would look like this, which should more or less work (I'm hoping):

SELECT citext_larger( 'Â'::citext, 'ç'::citext ) = 'ç' AS t WHERE false and test_multibyte();
 t
---
(0 rows)


Some time ago I raised the question of doing locale- and encoding- aware regression tests, and IIRC the consensus seemed to be that it was not worth the effort, but maybe we need to revisit that. We certainly seem to be doing a lot more work now to get Postgres to where it needs to be w.r.t. locale support, and we've cleaned up a lot of the encoding issues we had, so maybe we need to reflect that in our testing regime more.

Makes sense to me.

Best,

David


--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Reply via email to