On Thu, Jul 17, 2008 at 12:42:39PM -0400, Alvaro Herrera wrote: > Xiao Meng escribi?: > > The patch store hash code only in the index tuple. > > It based on Neil Conway's patch with an old version of PostgreSQL. > > It passes the regression test but I didn't test the performance yet. > > Anyone interested can make a performance test;-) > > You can undefine the macro HASHVALUE_ONLY in hash.h to get the > > original implementation. > > I think having the HASHVALUE_ONLY define is not a good idea -- it just > makes the patch harder to read. I suggest just removing the old code > and putting the new code in place. (That's why we have revision > control.) > One thing it helps is building an old version and a new version for comparative testing. Otherwise, you could end up with an apples-to- oranges comparison. I certainly think that the final patch should not have it, but it is useful now for testing and comparisons.
My two cents, Ken -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
