Wording adjusted and applied with attached patch.
---------------------------------------------------------------------------
Gurjeet Singh wrote:
> On Mon, Jun 30, 2008 at 7:33 PM, Tom Lane <[EMAIL PROTECTED]> wrote:
>
> > Alvaro Herrera <[EMAIL PROTECTED]> writes:
> > > In any case, this seems a case of stuffing too much in the primary
> > > message.
> >
> > Yeah, good point.
> >
> > > I think it should be something like
> > > errmsg("parameter \"shared_buffer\" change in configuration file
> > ignored"),
> > > errdetail("This parameter cannot be changed after server start.")
> >
> > Seems a bit awkwardly phrased. I propose
> >
> > errmsg("attempted change to parameter \"shared_buffer\" ignored"),
> > errdetail("This parameter cannot be changed after server start.")
> >
> > (or possibly "of" would read better than "to")
> >
> >
> 'of' sounds better than 'to'.
>
> Best regards,
> --
> [EMAIL PROTECTED]
> [EMAIL PROTECTED] gmail | hotmail | indiatimes | yahoo }.com
>
> EnterpriseDB http://www.enterprisedb.com
>
> Mail sent from my BlackLaptop device
--
Bruce Momjian <[EMAIL PROTECTED]> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ If your life is a hard drive, Christ can be your backup. +
Index: src/backend/utils/misc/guc-file.l
===================================================================
RCS file: /cvsroot/pgsql/src/backend/utils/misc/guc-file.l,v
retrieving revision 1.55
diff -c -c -r1.55 guc-file.l
*** src/backend/utils/misc/guc-file.l 9 May 2008 15:36:31 -0000 1.55
--- src/backend/utils/misc/guc-file.l 22 Aug 2008 00:01:00 -0000
***************
*** 258,265 ****
{
ereport(elevel,
(errcode(ERRCODE_CANT_CHANGE_RUNTIME_PARAM),
! errmsg("parameter \"%s\" cannot be changed after server start; configuration file change ignored",
! gconf->name)));
continue;
}
--- 258,266 ----
{
ereport(elevel,
(errcode(ERRCODE_CANT_CHANGE_RUNTIME_PARAM),
! errmsg("attempted change of parameter \"%s\" ignored",
! gconf->name),
! errdetail("This parameter cannot be changed after server start.")));
continue;
}
Index: src/backend/utils/misc/guc.c
===================================================================
RCS file: /cvsroot/pgsql/src/backend/utils/misc/guc.c,v
retrieving revision 1.466
diff -c -c -r1.466 guc.c
*** src/backend/utils/misc/guc.c 15 Aug 2008 08:37:40 -0000 1.466
--- src/backend/utils/misc/guc.c 22 Aug 2008 00:01:06 -0000
***************
*** 4598,4613 ****
if (changeVal && !is_newvalue_equal(record, value))
ereport(elevel,
(errcode(ERRCODE_CANT_CHANGE_RUNTIME_PARAM),
! errmsg("parameter \"%s\" cannot be changed after server start; configuration file change ignored",
! name)));
return true;
}
if (context != PGC_POSTMASTER)
{
ereport(elevel,
(errcode(ERRCODE_CANT_CHANGE_RUNTIME_PARAM),
! errmsg("parameter \"%s\" cannot be changed after server start",
! name)));
return false;
}
break;
--- 4598,4615 ----
if (changeVal && !is_newvalue_equal(record, value))
ereport(elevel,
(errcode(ERRCODE_CANT_CHANGE_RUNTIME_PARAM),
! errmsg("attempted change of parameter \"%s\" ignored",
! name),
! errdetail("This parameter cannot be changed after server start.")));
return true;
}
if (context != PGC_POSTMASTER)
{
ereport(elevel,
(errcode(ERRCODE_CANT_CHANGE_RUNTIME_PARAM),
! errmsg("attempted change of parameter \"%s\" ignored",
! name),
! errdetail("This parameter cannot be changed after server start.")));
return false;
}
break;
--
Sent via pgsql-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
