On Fri, Oct 31, 2008 at 10:15 PM, Heikki Linnakangas <[EMAIL PROTECTED]> wrote: > Fujii Masao wrote: >> >> And, there are some problems in this patch; >> >> * This patch is somewhat big, though it should be subdivided for >> review. >> >> * Source code comments and documents are insufficient. >> >> Is it against the rule of commit fest to add such a status patch >> into review-queue? If so, I would aim for 8.5. Otherwise, >> I will deal with the problems also during commit fest. >> What is your opinion? > > You can add work-in-progress patches and even just design docs to the > commitfest queue. That's perfectly OK. They will be reviewed as any other > work, but naturally if it's not a patch that's ready to be committed without > major work, it won't be committed. > > I haven't looked at the patch yet, but if you think there's chances to get > it into shape for inclusion to 8.4, before the commit fest is over, you can > and should keep working on it and submit updated patches during the commit > fest. However, help with reviewing other patches would also be very much > appreciated. The idea of commitfests is that everyone stops working on their > own stuff, except for cleaning up and responding to review comments on one's > own patches that are in the queue, and helps to review other people's > patches.
OK, thanks Heikki. I will keep working on Synch Rep during commit-fest. At first, as you say, I'll split the signal handling changes into an individual patch ASAP. Regards; -- Fujii Masao NIPPON TELEGRAPH AND TELEPHONE CORPORATION NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
