On Mon, Nov 10, 2008 at 11:03:37AM -0500, Tom Lane wrote:
> * before committing we need to see the proposed diffs to the Makefiles
> and the Windows build scripts.

Sure. I just committed the generated preproc.y file to see how it goes through
the buildfarm. I prefer to see the file is okay everywhere, before automating
things.

> * As-is, the first few lines of parse.pl contain an unportable hardwired
> assumption about where the perl executable is.  I'd suggest removing
> ...

Sure, this is just how a2p creates it.

> * Can we get a $PostgreSQL$ version identifier into each file that
> will be added to CVS?

Definitely.

Michael
-- 
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Michael at BorussiaFan dot De, Meskes at (Debian|Postgresql) dot Org
ICQ: 179140304, AIM/Yahoo: michaelmeskes, Jabber: [EMAIL PROTECTED]
Go VfL Borussia! Go SF 49ers! Use Debian GNU/Linux! Use PostgreSQL!

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Reply via email to