On Wed, Nov 12, 2008 at 02:28:56PM -0800, Ron Mayer wrote: > Merging of the interval style into ecpg attached.
Thanks for caring about the ecpg changes too. > I know little enough about ecpg that I can't really tell if these changes > are for the better or worse. The closer pgtypeslib is to the backend the better. > One thing in the patch that's probably a bug is that the > constants in src/include/utils/dt.h and src/include/utils/datetime.h > under the section "Fields for time decoding" seem not to match, so Assuming you mean src/interfaces/ecpg/pgtypeslib/dt.h. The numbers should match IMO. Also one files seems to be missing, there are no changes to test/expected/pgtypeslib-dt_test.c in the patch, but when changing dt_test.pgc this file should be changed too. Could you add this to your work too? Michael -- Michael Meskes Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org) Michael at BorussiaFan dot De, Meskes at (Debian|Postgresql) dot Org ICQ: 179140304, AIM/Yahoo: michaelmeskes, Jabber: [EMAIL PROTECTED] Go VfL Borussia! Go SF 49ers! Use Debian GNU/Linux! Use PostgreSQL! -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
