Alvaro Herrera escreveu: > So here's what looks like a committable patch. > > Note to self: remember to remove src/include/catalog/pg_autovacuum.h and > to bump catversion. > > Works for me. Just a few comments.
(i) I don't like this construction "by entries by changing storage parameters". I prefer "by changing storage parameters" or "by entries in pg_class.reloptions"; (ii) I think we should change the expression "storage parameters" for something else because autovacuum is related to maintenance. My suggestion is a general expression like "relation parameters"; (iii) I noticed that GUC defaults and relopt defaults are different (autovacuum_cost_delay and autovacuum_cost_limit). Is there any reason for not using -1? (iv) Maybe we should document that pg_dump will only dump reloptions like toast.foo iff the relation has an associated TOAST table. This seems obvious but ... -- Euler Taveira de Oliveira http://www.timbira.com/ -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
