Magnus Hagander wrote: > >>> Could pg_migrator detect usage of "objects" oids (data types in > >>> relation, index opclass, ...) that are unknown to be in the standard > >>> -core + contrib distribution, and quit trying to upgrade the cluster in > >>> this case, telling the user his database is not supported? > > > >> +1 on this. > > > >> Or at least, have it exit and say "if you know that these things are > >> reasonably safe, run pg_migrator again with --force" or something like > >> that. > > > > I don't think that anything in that line is going to be helpful. > > What it will lead to is people mindlessly using --force (cf our > > bad experiences with -i for pg_dump). If you can't give a *useful* > > ie trustworthy warning/error, issuing a useless one is not a good > > substitute. > > Well, in that case, error out would be a better option than doing it and > probably fail later. And have a --force option available, but don't > suggest it.
Uh, what doesn't error out now in pg_migrator? -- Bruce Momjian <br...@momjian.us> http://momjian.us EnterpriseDB http://enterprisedb.com + If your life is a hard drive, Christ can be your backup. + -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
