On Thu, 2009-06-25 at 09:51 -0400, Tom Lane wrote: > Simon Riggs <si...@2ndquadrant.com> writes: > > --- 610,621 ---- > > } > > break; > > case 'l': /* Use link */ > > ! /* > > ! * Link feature disabled, possibly permanently. > > Linking > > ! * causes a problem after recovery ends that is > > not currently > > ! * resolved by PostgreSQL. 25 Jun 2009 > > ! restoreCommandType = > > RESTORE_COMMAND_LINK; > > ! */ > > break; > > case 'r': /* Retries */ > > maxretries = atoi(optarg); > > Just for future reference: the above is going to look like hell after > pgindent gets its hands on it. Better style for this project is > > /* > * ordinary comment block > */ > #ifdef NOT_USED > code to be disabled > #endif
Will do, thanks. Patch to cleanup as advised is attached. -- Simon Riggs www.2ndQuadrant.com PostgreSQL Training, Services and Support
Index: contrib/pg_standby/pg_standby.c =================================================================== RCS file: /home/sriggs/pg/REPOSITORY/pgsql/contrib/pg_standby/pg_standby.c,v retrieving revision 1.25 diff -c -r1.25 pg_standby.c *** contrib/pg_standby/pg_standby.c 25 Jun 2009 12:03:10 -0000 1.25 --- contrib/pg_standby/pg_standby.c 25 Jun 2009 15:12:27 -0000 *************** *** 614,621 **** * Link feature disabled, possibly permanently. Linking * causes a problem after recovery ends that is not currently * resolved by PostgreSQL. 25 Jun 2009 ! restoreCommandType = RESTORE_COMMAND_LINK; ! */ break; case 'r': /* Retries */ maxretries = atoi(optarg); --- 614,623 ---- * Link feature disabled, possibly permanently. Linking * causes a problem after recovery ends that is not currently * resolved by PostgreSQL. 25 Jun 2009 ! */ ! #ifdef NOT_USED ! restoreCommandType = RESTORE_COMMAND_LINK; ! #endif break; case 'r': /* Retries */ maxretries = atoi(optarg);
-- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
