Dean Rasheed wrote: > Thanks for the thorough review. I attach an new version of the patch, > updated to HEAD, and with the index AM change discussed.
Wow, this is a large patch. I didn't do a thorough review, but some quickies I noticed: * Please move the code that says that it should be in a new file to a new file. * Please don't mimic the silliness of RI_FKey_check of an unused return value. Just make it return void, and have the caller use the proper PG_RETURN_FOO macro. (Unless there's a specific reason to not do things that way) * I'm not sure about the changes in trigger.h and related elsewhere. Seems related to the new list in AfterTriggerSaveEvent, which is used in ways that seem to conflict with its header comment ... I wonder if we should be doing that in the executor itself instead. In any case it's inconsistent that the list is added to ExecARInsertTriggers but not to ExecARUpdateTrigger et al ... -- Alvaro Herrera http://www.CommandPrompt.com/ The PostgreSQL Company - Command Prompt, Inc. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
