On Monday 03 August 2009 01:57:48 Tom Lane wrote: > Robert Haas <robertmh...@gmail.com> writes: > > > - The regression tests are gone? > > Tom added some that look adequate to me to create_index.sql, as a > > separate commit, so I don't think I need to do this in my patch any > > more. Maybe some of those examples should be changed to output JSON > > or XML, though, but I'd rather leave this up to Tom's discretion on > > commit because I think he has opinions about this and I think my > > chances of guessing what they are are low. > Well, of course the existing tests are not going to exercise XML or > JSON output format. Dunno how much we care. I had supposed that > XML or JSON would always emit all the fields and leave it to the > recipient to suppress what they don't want. If we want to have > platform-independent regression tests then we'd need to make the > COSTS option effective for XML/JSON format --- do we want that? Options such as COSTS do effect XML/JSON right now. While not important for COSTS itself, I think its generally good to do so because a certain option might not be done per default efficiencywise and I don't see a reason to specialcase COSTS.
Andres -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
