Grzegorz Jaskiewicz <g...@pointblue.com.pl> writes: > On 30 Aug 2009, at 19:14, Tom Lane wrote: >> Yes, it's bogus. ctid is never passed as NULL. It might point at >> an "invalid" itempointer (one with ip_posid == 0). Look at the only >> call site.
> so why do we check if the pointer is valid ? [ shrug... ] The macro is more general than is necessary in this specific context. In an actual build I'd expect the compiler to figure out that the null-pointer test is redundant and optimize it away, since after inlining it would see that ctid is the address of a local variable. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers