On fre, 2009-10-30 at 19:08 +0100, Pavel Stehule wrote: > 2009/10/30 Heikki Linnakangas <heikki.linnakan...@enterprisedb.com>: > > Pavel Stehule wrote: > >> 2009/10/30 Heikki Linnakangas <heikki.linnakan...@enterprisedb.com>: > >>> To keep the compiler quiet about using the variables uninitialized. The > >>> compiler doesn't know that ereport(ERROR) never returns. > >> > >> Should be similar code little bit commented? > > > > *shrug*, maybe, often we do put a "/* keep compiler quiet */" comment on > > such places. > > > > On closer look, the "Alternative possibility: default to RETURNS VOID" > > comment suggests that besides keeping the compiler quiet, those lines > > demonstrate an alternative behavior that was considered. > > I prefere "keep compiler quiet". It is cleaner - and it is used more times.
A while ago a patch was discussed (in the "clang checker" threat) that would teach the compiler that elog(>=ERROR) does not return, but I think it's not portable without further work. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
