On Sun, 2009-09-27 at 21:49 -0400, Robert Haas wrote: > On Wed, Sep 23, 2009 at 3:26 PM, Tom Lane <t...@sss.pgh.pa.us> wrote: > > Jaime Casanova <jcasa...@systemguards.com.ec> writes: > >> i extracted the functions to connect that Heikki put on psql in his > >> patch for determining client_encoding from client locale and put it in > >> libpq so i follow the PQconnectdbParams(* params[]) approach. > > > > I got around to looking at the actual patch a bit. I hadn't understood > > why it was so small, but now I do: it's implemented as a wrapper around > > PQconnectdb. That is, it takes the given keywords and values, and > > builds a conninfo string, which PQconnectdb then has to pull apart > > again.
> Based on this review, it sounds like this patch will need a major > rewrite before it can be seriously reviewed. Given that, I think it > makes sense to postpone this to the next CommitFest, so I am going to > mark it as Returned with Feedback. Is anyone planning to do further work on this? This appears to be blocking the client_encoding=auto feature. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
