Robert Haas <robertmh...@gmail.com> wrote: > I have reviewed this patch and I think it looks pretty good. A couple > of minor nits: > > - There are needless whitespace changes in the definition of struct > Counters. The changes to the existing four members should be > reverted, and the new members should be made to match the existing > members.
That's because the 'shared_blks_written' field is too long to keep the existing indentations. Since we still have some rooms in 80 columns, I'd like to change all of them as the previous patch. > - In the part that reads /* calc differences of buffer counters */, > all the lines go past 80 columns. I wonder if it would be better to > insert a line break just after the equals sign and indent the next > line by an extra tab stop. See, e.g. src/backend/commands/user.c line > 338. Ok, I'll adjust them so. Regards, --- Takahiro Itagaki NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
