On 1/12/10, Tom Lane <t...@sss.pgh.pa.us> wrote:
> Fujii Masao <masao.fu...@gmail.com> writes:
>  > I'm not sure whether poll(2) should be called for this purpose. But
>  > poll(2) and select(2) seem to often come together in the existing code.
>  > We should follow such custom?
>
>
> Yes.  poll() is usually more efficient, so it's preferred, but not all
>  platforms have it.  (On the other side, I think Windows might have
>  only poll and not select.)

FYI: on PL/Proxy we use poll() exclusively and on platforms
that dont have it (win32) we emulate poll() with select():

  
http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/plproxy/plproxy/src/poll_compat.c?rev=1.3&content-type=text/x-cvsweb-markup

End result is efficient and clean #ifdef-less code.

Something to consider.

-- 
marko

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Reply via email to