On Fri, 2010-01-15 at 13:28 +0200, Heikki Linnakangas wrote: > I think it's a premature optimization to skip writing the records if > we've written in the same session already. Especially with the > 'reason' > information added to the records, it's nice to have a record of each > such operation. All operations that skip WAL-logging are heavy enough > that an additional WAL record will make no difference. I can see that > it > was required to avoid the flooding from heap_insert(), but we can move > the XLogSkipLogging() call from heap_insert() to heap_sync().
Can we call that XLogReportUnloggedStatement() or similar? XlogSkipLogging() sounds like a request rather than a mark/report/record type of action. > Attached is an updated patch, doing the above. Am I missing anything? Sounds OK and works with Hot Standby. -- Simon Riggs www.2ndQuadrant.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
