committed

On fre, 2010-01-15 at 13:37 +0100, Christoph Berg wrote:
> There's not much I have to add, maybe the documentation could add a
> pointer to what keywords are recognized:
> 
> | The file uses an "INI file" format where the section name is the
> | service name and the parameters are connection parameters.
> 
> ... (see Section 30.1 for a list).

I added that.

> 
> Independently for what this patch changes, error reporting could be
> more detailed, currently "syntax error in service file \"%s\", line
> %d" is reported for "no = in line" and "keyword X is unknown". The
> latter case deserves a different message, maybe like "keyword \"%s\"
> is invalid in service file \"%s\", line %d".

That was a bit outside of the mandate of the patch, but if someone wants
to send in something for that, I'm sure it would be considered.


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Reply via email to