Tom Lane wrote: > 2. I renamed XLogCtl->RedoRecPtr to SavedRedoRecPtr, and renamed > the associated routines to SetSavedRedoRecPtr/GetSavedRedoRecPtr, > in hopes of reducing confusion.
Good. > 3. I believe it'd now be possible to remove SavedRedoRecPtr and > SetSavedRedoRecPtr/GetSavedRedoRecPtr entirely, in favor of letting > the postmaster fetch the updated pointer with GetRedoRecPtr just > like a backend would. This would be cleaner and less code ... but > someone might object that it introduces a risk of postmaster hangup, > if some backend crashes whilst holding info_lck. I consider that > risk minuscule given the short intervals in which info_lck is held, > but it can't be denied that the risk is not zero. Thoughts? The change sounds good to me. > Comments? Unless I hear objections I will patch this in current > and the 7.2 branch. (If we agree to remove SavedRedoRecPtr, > though, I don't think we should back-patch that change.) Totally agree. -- Bruce Momjian | http://candle.pha.pa.us [EMAIL PROTECTED] | (610) 853-3000 + If your life is a hard drive, | 830 Blythe Avenue + Christ can be your backup. | Drexel Hill, Pennsylvania 19026 ---------------------------(end of broadcast)--------------------------- TIP 6: Have you searched our list archives? http://archives.postgresql.org
