On Fri, 2010-01-29 at 14:04 -0500, Tom Lane wrote: > sri...@postgresql.org (Simon Riggs) writes: > > Log Message: > > ----------- > > Augment WAL records for btree delete with GetOldestXmin() to reduce > > false positives during Hot Standby conflict processing. Simple > > patch to enhance conflict processing, following previous discussions. > > Controlled by parameter minimize_standby_conflicts = on | off, with > > default off allows measurement of performance impact to see whether > > it should be set on all the time. > > WTF? Simon, this seems to be getting way way beyond anything the > community has agreed to. Particularly, inventing GUCs is not something > to be doing without consensus.
If you or anybody else would like me to revoke it then I am happy to do that, with no problem or argument. I agree it hasn't had discussion, though am happy to have such a discussion. The commit is a one line change, with parameter to control it, discussed by Heikki and myself in December 2008. I stand by the accuracy of the change; the parameter is really to ensure we can test during beta. I imagined such a minor addition would pass without comment. This is not the same patch not-being-discussed on the other thread, which is too complex for a commit without review. It is a separate change altogether, although it does relate to conflict processing. In any case I would never commit a patch while discussion on it continues. -- Simon Riggs www.2ndQuadrant.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
