What happened to this patch? ---------------------------------------------------------------------------
Itagaki Takahiro wrote: > > Merlin Moncure <[email protected]> wrote: > > > Takahiro<[email protected]> wrote: > > > contrib/dblink seems to have no treatments for query cancels. > > > (1) Users need to wait for completion of remote query. > > > (2) PGresult objects will be memory leak. > > Here is a patch to fix the issues. I hope the fixes will be ported > to older versions if possible. > > (1) is fixed by using non-blocking APIs in libpq. I think we should > always use non-blocking APIs even if the dblink function itself is > a blocking-function. > > (2) is fixed by RegisterXactCallback(AtEOXact_dblink). However, there > might be any better solutions -- for example, ResourceOwner framework. > > > > > For (1), asynchronous libpq functions should be used instead of blocking > > > ones, and wait for the remote query using a loop with > > > CHECK_FOR_INTERRUPTS(). > > > > How would you structure this loop exactly? > > Please check execute_query() and wait_for_result() in the patch. > > Regards, > --- > ITAGAKI Takahiro > NTT Open Source Software Center > [ Attachment, skipping... ] > > -- > Sent via pgsql-hackers mailing list ([email protected]) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgsql-hackers -- Bruce Momjian <[email protected]> http://momjian.us EnterpriseDB http://enterprisedb.com PG East: http://www.enterprisedb.com/community/nav-pg-east-2010.do + If your life is a hard drive, Christ can be your backup. + -- Sent via pgsql-hackers mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
