Magnus Hagander wrote: > On Tue, Apr 20, 2010 at 18:30, Tom Lane <t...@sss.pgh.pa.us> wrote: > > Robert Haas <robertmh...@gmail.com> writes: > >> Bruce suggested to me off-list that when I commit a patch with > >> revisions, I ought to attach the committed patch to the email in which > >> I say that I have committed it. ?I know that Bruce habitually does > >> this, but I've never found it very helpful, since I prefer to look at > >> the patch either using the pgsql-committers emails or the git > >> respository. > > > > I quite agree --- people who want to read the committed patch are going > > to go to the source, not to what somebody claims he committed. > > Yeah, +1. I always go to one of the other sources (most of the time, > the gitweb or git server). > > It doesn't hurt to attach it if it happens to be around, but I > wouldn't suggest spending any extra effort on it...
Well, many times I am applying a patch from an author that I have modified, and I don't expect them to be subscribed to committers, so I supply the patch as a courtesy so they can see my changes (and fix them). :-) -- Bruce Momjian <br...@momjian.us> http://momjian.us EnterpriseDB http://enterprisedb.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
