On Tue, 2010-04-27 at 18:08 -0400, Tom Lane wrote: > Simon Riggs <si...@2ndquadrant.com> writes: > > On Tue, 2010-04-27 at 17:24 -0400, Tom Lane wrote: > >> I think we should just lose that test, as well as the variable. > > > Yes, though it looks like it is still necessary in creating a valid > > initial state because otherwise we may have xids in KnownAssigned array > > that are already complete. > > Huh? How is a filter as coarse as an oldest-running-XID filter going > to prevent that? And aren't we initializing from trustworthy data in > ProcArrayApplyRecoveryInfo, anyway? > > I still say it's useless.
Quite possibly. Your looking at other code outside of this patch. I'm happy that you do so, but is it immediately related? I can have another look when we finish this. -- Simon Riggs www.2ndQuadrant.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
