Fujii Masao wrote: > On Thu, Apr 29, 2010 at 1:14 AM, Heikki Linnakangas > <heikki.linnakan...@enterprisedb.com> wrote: >> Ok, I've finally committed the patch, using wal_level as the name of the >> GUC. > >> ! if (InArchiveRecovery && XLogRequestRecoveryConnections) >> ! { >> ! if (ControlFile->wal_level < WAL_LEVEL_HOT_STANDBY) >> ! ereport(ERROR, >> ! (errmsg("recovery connections cannot >> start because wal_level was not set to 'hot_standby' on the WAL source >> server"))); > > I still have the complaint against the above check. Since the default value > of recovery_connections is TRUE, the users who need only archiving not > replication (i.e., wal_level is set to 'archive') are likely to often > see the failure > of the archive recovery by the above check.
Should we change the default to recovery_connections=off ? It is a quite big change in default behavior over previous releases that hot standby is enabled by default, so maybe that would be the right thing to do anyway. Or maybe add a hint to the above, "disable hot standby by setting recovery_connections=off, or set wal_level='hot_standby' in the primary" -- Heikki Linnakangas EnterpriseDB http://www.enterprisedb.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers