Tom Lane wrote: > Magnus Hagander <mag...@hagander.net> writes: >> On Thu, May 13, 2010 at 5:06 PM, Bruce Momjian <br...@momjian.us> wrote: >>> I have added SGML comments to comment out the text that mentions EDB >>> Advanced Server. Is that enough? Should I remove the text from the >>> SGML? Should I move it to the bottom of the SGML? Should I remove the >>> EnterpriseDB Advanced Server checks from the C code too? I don't >>> remember having to deal with anything like this before, so I am unclear >>> how to proceed. > >> I say remove it. On all accounts. > >> There's a fork of postgres for EDB AS, shouldn't there be a fork of >> pg_upgrade the same way, if it requires special code? The code in >> community postgresql certainly shouldn't have any EDB AS code in it. > > Indeed. Given the (presumably large) delta between EDB's code and ours, > having to have some delta in pg_upgrade isn't going to make much > difference for them. I think the community code and docs should > completely omit any mention of that.
Speaking as the person who has been doing the EDB AS merges recently, I agree. It was helpful to have that stuff there when it was in pgfoundry, but now that it's part of the main repository, it just gets in the way. -- Heikki Linnakangas EnterpriseDB http://www.enterprisedb.com -- Sent via pgsql-hackers mailing list (email@example.com) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers