On Wed, May 26, 2010 at 03:47:25PM -0400, Robert Haas wrote:
> On Tue, May 25, 2010 at 4:34 AM, Jonathan Leto <jal...@gmail.com> wrote:
> > This tiny doc patch adds _PG_init to the skeleton example code for a
> > PL. The information is quite valuable to PL authors, who might miss it
> > when it is described in the shared library documentation.
> 
> I'm not sure it does much good to add it to the template without any
> explanation of what it does.  What might make more sense is to add a
> cross-reference to the section on dynamic loading, where this is
> documented.

+1. How about the attached (which, incidentally, tested successfully on my
box, because I've managed to achieve doc building nirvana through blindly
flailing about until it worked...)?

--
Joshua Tolley / eggyknap
End Point Corporation
http://www.endpoint.com
diff --git a/doc/src/sgml/plhandler.sgml b/doc/src/sgml/plhandler.sgml
index b82a5da..1162bcf 100644
*** a/doc/src/sgml/plhandler.sgml
--- b/doc/src/sgml/plhandler.sgml
***************
*** 95,101 ****
     </para>
  
     <para>
!     This is a template for a procedural-language handler written in C:
  <programlisting>
  #include "postgres.h"
  #include "executor/spi.h"
--- 95,104 ----
     </para>
  
     <para>
!     This is a template for a procedural-language handler written in C. The
!     documentation on C-language functions found in <xref linkend="xfunc-c">
!     applies to language handlers as well as any other C functions, and may be
!     helpful to understand some portions of this code.
  <programlisting>
  #include "postgres.h"
  #include "executor/spi.h"

Attachment: signature.asc
Description: Digital signature

Reply via email to