On Thu, 2010-06-17 at 13:33 -0400, Tom Lane wrote: > Fujii Masao <masao.fu...@gmail.com> writes: > > On Wed, Jun 16, 2010 at 12:24 PM, Takahiro Itagaki > > <itagaki.takah...@oss.ntt.co.jp> wrote: > >> This is because pg_archivecleanup puts the line break "\n" in the head of > >> debug message. Why should we do so? > > > Yes. What about the attached patch? > > Applied along with a bit of further editorialization. > > >> Note that we don't need a line break at Line 130 > >> because strerror() fills the last %s. > >> L.130: fprintf(stderr, "\n%s: ERROR failed to remove \"%s\": %s", > > > Right. > > Huh? strerror() doesn't include a newline.
Thanks. -- Simon Riggs www.2ndQuadrant.com PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
