On Jun 21, 2010, at 11:47 AM, Kevin Grittner wrote: > Yes, although the line endings are Windows format (CR/LF).
The line endings must have gotten changed in transit. My original diff used just LF. I made it on a Mac. > The only issue is with the general guideline to make the new code > blend in with existing code: > > http://wiki.postgresql.org/wiki/Submitting_a_Patch > > | Generally, try to blend in with the surrounding code. > > | Comments are for clarification not for delineating your code from > | the surroundings. > > There are comments to set off the new code, and some of the new DATA > lines (and similar) are separated away from where one would expect > them to be if they had been included with the rest. Moving a few > lines and deleting a few comment lines would resolve it. I deleted the excess comments and moved some lines around. Here it is with the changes.
dividing-money.diff
Description: Binary data
-- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
