On Fri, 2010-07-16 at 21:10 +0200, Andres Freund wrote: > On Friday 16 July 2010 20:41:44 Andres Freund wrote: > > >> ! */ > > >> ! case AT_AddColumn: /* may > > >> rewrite heap, in some cases and visible to SELECT */ ! > > >> case AT_DropColumn: /* change > > >> visible to SELECT */ ! case > > >> AT_AddColumnToView: /* CREATE VIEW */ ! case > > >> AT_AlterColumnType: /* must rewrite heap */ ! > > >> case AT_DropConstraint: /* as DROP INDEX */ > > >> ! case AT_AddOids: > > >> ! case AT_DropOids: /* calls > > >> AT_DropColumn */ ! case > > >> AT_EnableAlwaysRule: /* as DROP INDEX */ ! > > >> case AT_EnableReplicaRule: /* as DROP INDEX */ > > >> ! case AT_EnableRule: /* as DROP > > >> INDEX */ > Another remark: > > Imho it would be usefull to keep that list in same order as in the enum - > currently its hard to make sure no case is missing.
Not really; the default case is to reject, so any full test suite will pick that up. The cases are ordered by resulting lock type, which seemed the best way to check we didn't accidentally assign an incorrect lock type. -- Simon Riggs www.2ndQuadrant.com PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
