Rod Taylor wrote:
> [ copied to hackers ]
> 
> > 1. I don't like the code that installs and removes ad-hoc
> dependencies
> > from relations to type Oid.  On its own terms it's wrong (if it were

Looks good to me.  I realize this is a huge chunk of code.  The only
ultra-minor thing I saw was the use of dashes for comment blocks when
not needed:

        /*  ----
         *  word
         *  ----
         */

We use dashes like this only for comments that shouldn't be reformatted
by pgindent.

The one thing I would like to know is what things does it track, and
what does it not track?  Does it complete any TODO items, or do we save
that for later?

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  [EMAIL PROTECTED]               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

---------------------------(end of broadcast)---------------------------
TIP 3: if posting/reading through Usenet, please send an appropriate
subscribe-nomail command to [EMAIL PROTECTED] so that your
message can get through to the mailing list cleanly

Reply via email to