On 2010-08-24 8:25 AM +0300, igor polishchuk wrote:
Marko et al,
This is my first ever attempt of a patch review just for learning the
procedure. I'm not a postgres developer, so the review is partial and mostly
from the usability prospective.
That's all right. I'm sure any help is appreciated.
The patch provides a HINT for unclear error. This should clarify for a user
what exactly is wrong with the sql.
However, the actual HINT text provided with the patch is not very clear,
too.
The Stephen Frost's suggestion would add clarity:
errhint("insert appears to be a single column with a record-type rather than
multiple columns of non-composite type."),
This isn't entirely accurate, either; the columns are not necessarily of
non-composite types.
Regards,
Marko Tiikkaja
--
Sent via pgsql-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
