On 09/20/2010 09:06 PM, Tom Lane wrote:
Stefan Kaltenbrunner<ste...@kaltenbrunner.cc> writes:
http://lists.nongnu.org/archive/html/info-cvs/2004-07/msg00106.html
is what I'm refering too and what the debian people provided a patch to
work around for(starting with1:1.12.9-17 in 2005) - nut sure why you are
not seeing it...
Hm, that is talking about the output of "cvs log". It doesn't say
anything one way or the other about what gets put into $Header$ keyword
expansions. A look into the 1.12.13 source code says that dates in
keywords are always printed with this:
sprintf (buf, "%04d/%02d/%02d %02d:%02d:%02d", year, mon, mday,
hour, min, sec);
(see printable_date in src/rcs.c). So I'm still of the opinion that
debian fixed that which wasn't broken. I tried searching the nongnu
archives and found this:
http://lists.nongnu.org/archive/html/info-cvs/2004-03/msg00359.html
which leads me to think that the upstream developers considered and
ultimately rejected moving to ISO style in keyword expansion. Probably
the debian maintainer decided he knew better and changed it anyway;
there seems to be a lot of that going around among debian packagers.
wow - now that I look closer it seems you are right...
The patch in debian against the upstream package (see:
http://ftp.de.debian.org/debian/pool/main/c/cvs/cvs_1.12.13-12.diff.gz)
has this hunk:
--- cvs-1.12.13-old/src/rcs.c 2006-02-26 23:03:04.000000000 +0800
+++ cvs-1.12.13/src/rcs.c 2006-02-26 23:03:05.000000000 +0800
@@ -33,6 +33,8 @@
# endif
#endif
+int datesep = '-';
+
/* The RCS -k options, and a set of enums that must match the array.
These come first so that we can use enum kflag in function
prototypes. */
@@ -3537,8 +3539,8 @@
&sec);
if (year < 1900)
year += 1900;
- sprintf (buf, "%04d/%02d/%02d %02d:%02d:%02d", year, mon, mday,
- hour, min, sec);
+ sprintf (buf, "%04d%c%02d%c%02d %02d:%02d:%02d", year, datesep, on,
+ datesep, mday, hour, min, sec);
return xstrdup (buf);
}
so the broke that in early 2006 and nobody noticed so far...
Stefan
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
