Tom Lane wrote: > Bruce Momjian <br...@momjian.us> writes: > > Tom Lane wrote: > >> Bruce Momjian <br...@momjian.us> writes: > >>> Looking at the pg_upgrade code some more, I found that it was not > >>> removing the PG_VERSION file when deleting <= 8.4 tablespace files. > >>> This might confuse administrators so the attached patch adds the removal > >>> of PG_VERSION. I would like to apply this to master and 9.0.X. > >> > >> ... why is that a good idea? > > > The script already deletes the 8.4 database directories, but leaves > > PG_VERSION behind. Why keep it when all the 8.4 data is gone? The > > script also dates PGDATA for 8.4, so there is nothing left pointing to > > that directory. > > Oh, I misunderstood: I thought you were proposing to do this as an > automatic action inside pg_upgrade. If it's part of the cleanup script, > it's fine.
Yes, never automatic. You can always roll back after pg_upgrade completes. Once you start the new server, only then can you not go back. -- Bruce Momjian <br...@momjian.us> http://momjian.us EnterpriseDB http://enterprisedb.com + It's impossible for everything to be true. + -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
