Robert Haas <[email protected]> writes:
> On Sun, Jan 30, 2011 at 5:47 PM, Tom Lane <[email protected]> wrote:
>> If you don't want to commit it yourself, I'll take it.
> I'm happy to do it. I would have done it straight off, but thought
> I'd give everyone one last chance to kvetch.
Just in a quick read-through of the patches, the only things I noticed
were (1) lack of a PGDG copyright notice in errcodes.txt, and (2)
in your proposed change to generate-errcodes.pl:
+ # Omit a comment for each section header
+ if (/^Section:(.*)/) {
+ my $header = $1;
+ $header =~ s/^\s+//;
+ print "\n/* $header */\n";
+ next;
+ }
ITYM "Emit" not "Omit"?
regards, tom lane
--
Sent via pgsql-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
